feat: Add support for interpolator #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
dnerini
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running the interpolator on GRIB files from forecaster models, enabling interpolation on file-based inputs rather than just analysis data.
Key changes:
- Added support for interpolation from GRIB files with different reference date handling
- Enhanced pre-processors to work with State objects instead of just FieldList objects
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/anemoi/inference/runners/interpolator.py | Added file-based interpolation support and device management |
| src/anemoi/inference/runners/default.py | Added distributed process group cleanup and reference date handling |
| src/anemoi/inference/runner.py | Enhanced with distributed computing, improved tensor operations, and better device handling |
| src/anemoi/inference/pre_processors/no_missing_values.py | Updated to process State objects instead of FieldList |
| src/anemoi/inference/pre_processors/forward_transform_filter.py | Updated to process State objects instead of FieldList |
| src/anemoi/inference/pre_processors/extract.py | New processor for extracting subsets of data using masks or slices |
| src/anemoi/inference/inputs/gribfile.py | Added support for reference date index parameter |
| src/anemoi/inference/inputs/ekd.py | Enhanced state creation with reference date support and improved pre-processing |
| src/anemoi/inference/inputs/cutout.py | Added kwargs support for input state creation |
| src/anemoi/inference/device.py | Enhanced device selection with distributed computing support |
| src/anemoi/inference/config/init.py | Relaxed configuration validation to allow extra fields |
| pyproject.toml | Updated omegaconf version constraint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks for this! As you say, I think we first need to discuss how to bring this functionality into the codebase. I think this would be a good topic for in two weeks when Harrison and I are in Zurich ? |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
HCookie
requested changes
Oct 15, 2025
Co-authored-by: Harrison Cook <[email protected]>
Co-authored-by: Harrison Cook <[email protected]>
for more information, see https://pre-commit.ci
HCookie
reviewed
Oct 15, 2025
HCookie
reviewed
Oct 15, 2025
gmertes
approved these changes
Oct 15, 2025
HCookie
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for running the interpolator on:
Related to #345
Close #310
What issue or task does this change relate to?
N/A
Additional notes
This draft includes all the changes introduced by @OpheliaMiralles in anemoi-inference in order to run interpolation. We should have a discussion on what changes should be factored out in a separate PR.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.